linux-kernel - Re: [PATCH 4/5] mvme147: Scsi_Cmnd to struct scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Sep 2006 15:23:33 -0500
From:	James Bottomley <James.Bottomley@...elEye.com>
To:	Henne <henne@...htwindheim.de>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] mvme147: Scsi_Cmnd to struct scsi_cmnd convertion

On Tue, 2006-09-12 at 20:31 +0200, Henne wrote:
> Changes obsolete typedef'd Scsi_Cmnd to struct scsi_cmnd.
> Signed-off-by: Henrik Kretzschmar <henne@...htwindheim.de>

Actually, just a single patch for all the coupled drivers would be
better, please.

> -int wd33c93_queuecommand(Scsi_Cmnd *, void (*done)(Scsi_Cmnd *));
> -int wd33c93_abort(Scsi_Cmnd *);
> -int wd33c93_reset(Scsi_Cmnd *, unsigned int);
> +int wd33c93_queuecommand(struct scsi_cmnd *, void (*done)(struct scsi_cmnd *));
> +int wd33c93_abort(struct scsi_cmnd *);
> +int wd33c93_reset(struct scsi_cmnd *, unsigned int);

These prototypes are all unnecessary and can be pulled out of the
individual header files.  The first two are provided by wd33c93.h and
the last one isn't actually in the body of any file.

wd33c93_info is also unused and can go.

Thanks,

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/