linux-kernel - Re: kernel BUGs when removing largish files with the SLOB allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Sep 2006 22:59:45 +0100
From:	David Howells <dhowells@...hat.com>
To:	Matt Mackall <mpm@...enic.com>
Cc:	David Howells <dhowells@...hat.com>, Aubrey <aubreylee@...il.com>,
	Nick Piggin <nickpiggin@...oo.com.au>,
	linux-kernel@...r.kernel.org, davidm@...pgear.com,
	gerg@...pgear.com
Subject: Re: kernel BUGs when removing largish files with the SLOB allocator 

Matt Mackall <mpm@...enic.com> wrote:

> The only tricky part is the timer points back to _this very function_.

OIC.  Brrr.  That _definitely_ needs commenting - as has been demonstrated.
SLOB is using the theoretically one-shot initiator to do garbage collection.

The:

			if (size == PAGE_SIZE) /* trying to shrink arena? */
				return 0;

In slob_alloc() definitely looks very dodgy, now that I see it.  What happens
if some normal user asks to allocate exactly a page?  Oh... I suppose it never
gets into slob_alloc() to allocate the main piece of storage.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/