linux-kernel - Re: [PATCH 4/7] Implement a general integer log2 facility in the kernel [try #3]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060914111948.3c11242d.sfr@canb.auug.org.au>
Date:	Thu, 14 Sep 2006 11:19:48 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...l.org, akpm@...l.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH 4/7] Implement a general integer log2 facility in the
 kernel [try #3]

Hi David,

Just a small nit ...

On Wed, 13 Sep 2006 19:35:29 +0100 David Howells <dhowells@...hat.com> wrote:
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 681dea8..b4b4eae 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -784,9 +782,9 @@ static int ext2_fill_super(struct super_
>  	sbi->s_sbh = bh;
>  	sbi->s_mount_state = le16_to_cpu(es->s_state);
>  	sbi->s_addr_per_block_bits =
> -		log2 (EXT2_ADDR_PER_BLOCK(sb));
> +		ilog2 (EXT2_ADDR_PER_BLOCK(sb));
>  	sbi->s_desc_per_block_bits =
> -		log2 (EXT2_DESC_PER_BLOCK(sb));
> +		ilog2 (EXT2_DESC_PER_BLOCK(sb));

While you are here, could you get rid of the spaces before the parentheses?

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/