linux-kernel - Re: [PATCH 4/11] LTTng-core 0.5.108 : core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Sep 2006 09:43:06 +0200
From:	Martin Waitz <tali@...ingilde.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...l.org>, Ingo Molnar <mingo@...hat.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tom Zanussi <zanussi@...ibm.com>, ltt-dev@...fik.org,
	Michel Dagenais <michel.dagenais@...ymtl.ca>
Subject: Re: [PATCH 4/11] LTTng-core 0.5.108 : core

hoi :)

On Wed, Sep 13, 2006 at 11:43:08PM -0400, Mathieu Desnoyers wrote:
> +int ltt_module_register(enum ltt_module_function name, void *function,
> +		struct module *owner)
> +{
> +	int ret = 0;
> +	
> +	/* Protect these operations by disallowing them when tracing is
> +	 * active */
> +	if(ltt_traces.num_active_traces) {
> +		ret = -EBUSY;
> +		goto end;
> +	}

what would happen otherwise?
can it happen that someone enables tracing between this check and
the rest of the function?

> +	new_trace->transport = transport;
> +	new_trace->ops = &transport->ops;
> +
> +	err = -new_trace->ops->create_dirs(new_trace);
              ^ typo or intentional?


-- 
Martin Waitz

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)