linux-kernel - Re: [PATCH] mpparse.c:231: warning: comparison is always false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060915152349.GA22233@redhat.com>
Date:	Fri, 15 Sep 2006 11:23:49 -0400
From:	Dave Jones <davej@...hat.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	Jarek Poplawski <jarkao2@...pl>, Andi Kleen <ak@....de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mpparse.c:231: warning: comparison is always false

On Fri, Sep 15, 2006 at 01:23:02AM -0700, Andrew Morton wrote:

 > > > Thanks.   Andi has already queued a similar patch.
 > > > 
 > > > Andi, you might as well scoot that upstream, otherwise we'll get lots of
 > > > emails about it.
 > > ...
 > > > > +#if 0xFF >= MAX_MP_BUSSES
 > > > >  	if (m->mpc_busid >= MAX_MP_BUSSES) {
 > > I don't know how Andi has fixed it,
 > Same thing.  (He has `#if MAX_MP_BUSSES < 256').

How can this be the right the right thing to do ?
It should *never* be >=256. mach-summit/mach-generic need fixing
to be 255, not this ridiculous band-aid.  Where did 260 come from anyway?
 
	Dave 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/