linux-kernel - Re: [RFC] Alignment of fields in struct dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200609152244.07889.arnd@arndb.de>
Date:	Fri, 15 Sep 2006 22:44:07 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Jörn Engel <joern@...nheim.fh-wedel.de>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC] Alignment of fields in struct dentry

Am Friday 15 September 2006 12:27 schrieb Jörn Engel:
> -};
> +}__attribute__((aligned(64))); /* make sure the dentry is 128/192 bytes
> +                                  on 32/64 bit independently of config
> +                                  options.  d_iname will vary in length
> +                                  a bit. */

I'd guess that a 32 byte alignment is much better here, 64 byte sounds
excessive. It should have the same effect with the current dentry layout
and default config options, but would keep the d_iname length in the
16-44 byte range instead of 16-76 byte as your patch does.

Since all important fields are supposed to be kept in 32 bytes anyway,
they are still either at the start or the end of a given cache line,
but never cross two.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/