linux-kernel - Re: [PATCH 5 of 11] XFS: Use SEEK_{SET, CUR, END} instead of hardcoded values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Sep 2006 11:30:35 +0100
From:	David Howells <dhowells@...hat.com>
To:	David Chinner <dgc@....com>
Cc:	"Josef 'Jeff' Sipek" <jeffpc@...efsipek.net>,
	linux-kernel@...r.kernel.org, xfs-masters@....sgi.com,
	akpm@...l.org, dhowells@...hat.com
Subject: Re: [PATCH 5 of 11] XFS: Use SEEK_{SET, CUR, END} instead of hardcoded values 

David Chinner <dgc@....com> wrote:

> The hard coded values  used in xfs_change_file_space() are documented as part
> of the API to the userspace functions that use this interface in xfsctl(3).

Hmmm... that's a good point.  I think you're right on this account, and so the
comments in:

		case 0: /*SEEK_SET*/
			break;
		case 1: /*SEEK_CUR*/
			bf->l_start += offset;
			break;
		case 2: /*SEEK_END*/
			bf->l_start += ip->i_d.di_size;
			break;

should be stripped off as they are not exactly correct.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/