linux-kernel - Re: [linux-pm] [RFC] CPUFreq PowerOP integration, Centrino PM Core and OPs registration 2/3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <450E802B.800@gmail.com>
Date:	Mon, 18 Sep 2006 15:16:59 +0400
From:	"Eugeny S. Mints" <eugeny.mints@...il.com>
To:	Pavel Machek <pavel@....cz>
CC:	pm list <linux-pm@...ts.osdl.org>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [linux-pm] [RFC] CPUFreq PowerOP integration, Centrino PM Core
 and OPs registration 2/3

Pavel Machek wrote:
> Hi!
> 
>> +/* 
>> + * FIXME: very temporary implementation, just to prove the concept !! 
>> + */
>> +static int 
>> +process_pwr_param(struct pm_core_point *opt, int op, char *param_name,
>> +		  int va_arg)
> 
> Ok, so can we get final implementation? Parsing strings in drivers is
> evil...
ok, i saw this your comment when you mentioned it for the first time and I 
explicitly put it in TODO letter sent along with the patchset.

Can you instead of such implementation details try to review and give us your 
comments if any on interfaces approach and namely on cpufreq/PowerOP integration 
at cpufreq_driver layer; comments _based_ on the code. The issue with string 
parsing does not affect cpufreq/PowerOP integration interfaces since currently I 
keep going with parameter names(strings) interface for PowerOP Core regardless 
of whether parsing will eventually occur - at PM Core or POwerOP Core.

	Eugeny
> 
> 									Pavel
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/