linux-kernel - Re: Exporting array data in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d120d5000609180759t42945f0bi496b3840818c218b@mail.gmail.com>
Date:	Mon, 18 Sep 2006 10:59:16 -0400
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Rolf Eike Beer" <eike-kernel@...tec.de>
Cc:	"Greg KH" <greg@...ah.com>, linux-kernel@...r.kernel.org
Subject: Re: Exporting array data in sysfs

On 9/18/06, Rolf Eike Beer <eike-kernel@...tec.de> wrote:
> Dmitry Torokhov wrote:
> > On 9/18/06, Rolf Eike Beer <eike-kernel@...tec.de> wrote:
> > > Greg KH wrote:
> > > > On Mon, Sep 18, 2006 at 01:59:17PM +0200, Rolf Eike Beer wrote:
> > > > > Hi,
> > > > >
> > > > > I would like to put the contents of an array in sysfs files. I found
> > > > > no simple way to do this, so here are my thoughts in hope someone can
> > > > > hand me a light.
> > > >
> > > > What is wrong with using an attribute group for this kind of
> > > > information?
> > >
> > > Missing documentation. Yes, this looks like I could use this at least for
> > > the simple interfaces (which would be enough).
> >
> > I imoplemented sysfs arrays and array groups once:
> >
> > http://www.ussg.iu.edu/hypermail/linux/kernel/0503.2/1155.html
> >
> > Not sure if it still appliers. Maybe Greg will consider taking it in
> > if there is a user of this code.
>
> I guess we can add some once it is in :)
>
> It looks good, but I would change some minor things. If there is no read
> function given I would return -EIO instead of 0, this is how other places do
> it.

Yes, the patch was done when everyone returned 0 instead of -EIO. Also
there is kmalloc->kzalloc conversion, etc.

> The limitation to 999 entries should go.

It is not really a limitation but rather a safeguard. Do you really
expect to have arrays with that many attributes?

> But otherwise it looks very
> similar to what I had in mind.
>
> Thanks.
>
> Eike
>
>
>

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/