linux-kernel - Re: [PATCH] scsi-driver ultrastore replace Scsi_Cmnd with struct scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060918185321.GB17670@infradead.org>
Date:	Mon, 18 Sep 2006 19:53:21 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Henne <henne@...htwindheim.de>
Cc:	Andrew Morton <akpm@...l.org>, James.Bottomley@...elEye.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi-driver ultrastore replace Scsi_Cmnd with struct scsi_cmnd

On Wed, Sep 06, 2006 at 10:49:48AM +0200, Henne wrote:
> From: Henrik Kretzschmar <henne@...htwindheim.de>
> 
> Replaces the typedef'd Scsi_Cmnd with struct scsi_cmnd.
> Signed-off-by: Henrik Kretzschmar <henne@...htwindheim.de>

Looks good to me.  It would be even better if you could update the
driver to not require

	#include "scsi.h"

anymore and get rid of ultrastor.h.  Also your mailer unfortunately
damages tabs.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/