linux-kernel - Re: [PATCH 4/7] SLIM: secfs patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060918205412.GA2640@redhat.com>
Date:	Mon, 18 Sep 2006 16:54:12 -0400
From:	Dave Jones <davej@...hat.com>
To:	Kylene Jo Hall <kjhall@...ibm.com>
Cc:	Stephen Smalley <sds@...ho.nsa.gov>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	LSM ML <linux-security-module@...r.kernel.org>,
	Dave Safford <safford@...ibm.com>,
	Mimi Zohar <zohar@...ibm.com>,
	Serge Hallyn <sergeh@...ibm.com>, akpm@...l.org
Subject: Re: [PATCH 4/7] SLIM: secfs patch

On Mon, Sep 18, 2006 at 01:50:42PM -0700, Kylene Jo Hall wrote:

 > > > This patch provides the securityfs used by SLIM.

nitpick. (I never reviewed this when it was posted, but this followup
caught my eye..)

 > > > --- linux-2.6.18/security/slim/slm_secfs.c	1969-12-31 16:00:00.000000000 -0800
 > > > +++ linux-2.6.17-working/security/slim/slm_secfs.c	2006-09-06 11:49:09.000000000 -0700
 > > > @@ -0,0 +1,73 @@
 > > > +/*
 > > > + * SLIM securityfs support: debugging control files
 > > > + *
 > > > + * Copyright (C) 2005, 2006 IBM Corporation
 > > > + * Author: Mimi Zohar <zohar@...ibm.com>
 > > > + *	   Kylene Hall <kjhall@...ibm.com>
 > > > + *
 > > > + *      This program is free software; you can redistribute it and/or modify
 > > > + *      it under the terms of the GNU General Public License as published by
 > > > + *      the Free Software Foundation, version 2 of the License.
 > > > + */
 > > > +
 > > > +#include <asm/uaccess.h>
 > > > +#include <linux/config.h>

You don't need to include config.h any more, kbuild does it for you.
(Might want to check the other files for the same thing).

	Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/