linux-kernel - [PATCH] wistron: fix detection of special buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200609191623.49407.reiner@reiner-h.de>
Date:	Tue, 19 Sep 2006 16:23:48 +0200
From:	Reiner Herrmann <reiner@...ner-h.de>
To:	mitr@...ny.cz
Cc:	dtor@...l.ru, linux-kernel@...r.kernel.org
Subject: [PATCH] wistron: fix detection of special buttons

If either a wifi or a bluetooth button has been detected, the code
would break off the loop. But there are laptops that have both types of buttons,
so the loop has to continue checking.

Signed-off-by: Reiner Herrmann <reiner@...ner-h.de>
---
diff -uprN -X linux-2.6.18-rc7/Documentation/dontdiff linux-2.6.18-rc7/drivers/input/misc/wistron_btns.c linux-work/drivers/input/misc/wistron_btns.c
--- linux-2.6.18-rc7/drivers/input/misc/wistron_btns.c	2006-09-14 16:08:18.000000000 +0200
+++ linux-work/drivers/input/misc/wistron_btns.c	2006-09-19 16:03:30.000000000 +0200
@@ -248,13 +248,10 @@ static int __init dmi_matched(struct dmi
 
 	keymap = dmi->driver_data;
 	for (key = keymap; key->type != KE_END; key++) {
-		if (key->type == KE_WIFI) {
+		if (key->type == KE_WIFI)
 			have_wifi = 1;
-			break;
-		} else if (key->type == KE_BLUETOOTH) {
+		else if (key->type == KE_BLUETOOTH)
 			have_bluetooth = 1;
-			break;
-		}
 	}
 	return 1;
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/