linux-kernel - Re: [linux-usb-devel] [PATCH] USB: consolidate error values from EHCI, UHCI and OHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0609191630470.4631-100000@iolanthe.rowland.org>
Date:	Tue, 19 Sep 2006 16:32:47 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	David Brownell <david-b@...bell.net>
cc:	Jiri Kosina <jikos@...os.cz>, Andrew Morton <akpm@...l.org>,
	<dbrownell@...rs.sourceforge.net>, <weissg@...nna.at>,
	<linux-usb-devel@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [linux-usb-devel] [PATCH] USB: consolidate error values from
 EHCI, UHCI and OHCI _suspend()

On Tue, 19 Sep 2006, David Brownell wrote:

> Eventually we want hcd->state to vanish, but until it does it sure seems
> like a problem if usbcore can't rely on all HCDs to treat it the same.

uhci-hcd sets hcd->state wherever needed by usbcore, just as the other 
HCDs do.  (At least that was my intention -- if I missed setting it 
somewhere then the driver should be fixed.)

But uhci-hcd never reads hcd->state or tests its value.  I think that's 
what Jiri meant.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/