linux-kernel - RE: [patch 3/3] Add tsi108 On Chip Ethernet device driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7EA18FDD2DC2154AA3BD6D2F22A62A0E2FB214@zch01exm23.fsl.freescale.net>
Date:	Tue, 19 Sep 2006 15:39:54 +0800
From:	"Zang Roy-r61911" <tie-fei.zang@...escale.com>
To:	"Arjan van de Ven" <arjan@...radead.org>
Cc:	"Andrew Morton" <akpm@...l.org>, "jgarzik" <jgarzik@...ox.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [patch 3/3] Add tsi108 On Chip Ethernet device driver support

> 
> I have some review comments about your driver; please 
> consider them for
> fixing....
> 
Thanks.
> 
> > +		spin_unlock_irq(&phy_lock);
> > +		msleep(10);
> > +		spin_lock_irq(&phy_lock);
> > +	}
> 
> hmm some places take phy_lock with disabling interrupts, while others
> don't. I sort of fear "the others" may be buggy.... are you sure those
> are ok?
Could you interpret your comments in detail?
Roy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/