linux-kernel - Re: [PATCH 4/4] Blackfin: binfmt patch to enhance stacking checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1158830520.11109.91.camel@localhost.localdomain>
Date:	Thu, 21 Sep 2006 10:22:00 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Luke Yang <luke.adi@...il.com>
Cc:	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH 4/4] Blackfin: binfmt patch to enhance stacking checking

Ar Iau, 2006-09-21 am 11:33 +0800, ysgrifennodd Luke Yang:
> diff -urN linux-2.6.18.patch2/fs/binfmt_elf_fdpic.c
> linux-2.6.18.patch3/fs/binfmt_elf_fdpic.c
> --- linux-2.6.18.patch2/fs/binfmt_elf_fdpic.c	2006-09-21
> 09:37:18.000000000 +0800
> +++ linux-2.6.18.patch3/fs/binfmt_elf_fdpic.c	2006-09-21
> 11:17:49.000000000 +0800
> @@ -959,6 +962,8 @@
>  }
>  #endif
> 
> +extern void *safe_dma_memcpy(void *, const void *, size_t);
> +

This shouldn't be here but in your header files for the arch (or in
linux/ somewhere if its a shared and missing include). Check and fix the
headers.



>  		if (strncmp(hdr->magic, "#!", 2))
>  			printk("BINFMT_FLAT: bad header magic\n");
> -		ret = -ENOEXEC;
> -		goto err;
> +		return -ENOEXEC;

These changes seem unneccessary and its hard to see the real change as a
result.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/