linux-kernel - Re: [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d6a94c50609210223o5adf9bb5w7bfb70fb59094c85@mail.gmail.com>
Date:	Thu, 21 Sep 2006 17:23:52 +0800
From:	Aubrey <aubreylee@...il.com>
To:	"Alan Cox" <alan@...rguk.ukuu.org.uk>
Cc:	"Luke Yang" <luke.adi@...il.com>, linux-kernel@...r.kernel.org,
	"Andrew Morton" <akpm@...l.org>
Subject: Re: [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18

On 9/21/06, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> Ar Iau, 2006-09-21 am 11:33 +0800, ysgrifennodd Luke Yang:
> > Hi,
> >
> > This is the serial driver for Blackfin. It is designed for the serial
> > core framework.
>
> > +#define DMA_RX_XCOUNT                TTY_FLIPBUF_SIZE
>
> TTY_FLIPBUF_SIZE is going away. Just pick a value good for your hardware
> and under PAGE_SIZE.

Thanks for your comments. I'll change it soon and submit a new patch.

>
> Other question - is your locking ok for low latency. In low latency mode
> tty_flip_buffer_push() may directly end up calling your write methods.
>
Yes, I noticed that and I think it's ok. The driver is tested everday
and works fine.

-Aubrey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/