linux-kernel - Re: [PATCH -mm 3/6] swsusp: Use block device offsets to identify swap locations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Sep 2006 23:30:21 +0200
From:	Pavel Machek <pavel@....cz>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Andrew Morton <akpm@...l.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm 3/6] swsusp: Use block device offsets to identify swap locations

Hi!

> Make swsusp use block device offsets instead of swap offsets to identify swap
> locations and make it use the same code paths for writing as well as for
> reading data.
> 
> This allows us to use the same code for handling swap files and swap
> partitions and to simplify the code, eg. by dropping rw_swap_page_sync().
> 
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>

ACK. You may want to fix the comments, but that's probably separate
patch.


> Index: linux-2.6.18-rc7-mm1/mm/swapfile.c
> ===================================================================
> --- linux-2.6.18-rc7-mm1.orig/mm/swapfile.c
> +++ linux-2.6.18-rc7-mm1/mm/swapfile.c
> @@ -945,6 +945,23 @@ sector_t map_swap_page(struct swap_info_
>  	}
>  }
>  
> +#ifdef CONFIG_SOFTWARE_SUSPEND
> +/*
> + * Get the (PAGE_SIZE) block corrsponding to given offset on the swapdev

corresponding?

> + * corrsponding to given index in swap_info (swap type).

here too...


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/