linux-kernel - Re: [PATCH -mm 3/6] swsusp: Use block device offsets to identify swap locations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Sep 2006 00:21:29 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Pavel Machek <pavel@....cz>
Cc:	Andrew Morton <akpm@...l.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm 3/6] swsusp: Use block device offsets to identify swap locations

On Thursday, 21 September 2006 23:30, Pavel Machek wrote:
> Hi!
> 
> > Make swsusp use block device offsets instead of swap offsets to identify swap
> > locations and make it use the same code paths for writing as well as for
> > reading data.
> > 
> > This allows us to use the same code for handling swap files and swap
> > partitions and to simplify the code, eg. by dropping rw_swap_page_sync().
> > 
> > Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> 
> ACK. You may want to fix the comments, but that's probably separate
> patch.
> 
> 
> > Index: linux-2.6.18-rc7-mm1/mm/swapfile.c
> > ===================================================================
> > --- linux-2.6.18-rc7-mm1.orig/mm/swapfile.c
> > +++ linux-2.6.18-rc7-mm1/mm/swapfile.c
> > @@ -945,6 +945,23 @@ sector_t map_swap_page(struct swap_info_
> >  	}
> >  }
> >  
> > +#ifdef CONFIG_SOFTWARE_SUSPEND
> > +/*
> > + * Get the (PAGE_SIZE) block corrsponding to given offset on the swapdev
> 
> corresponding?
> 
> > + * corrsponding to given index in swap_info (swap type).
> 
> here too...

Ouch, thanks.

I think I'll repost the whole series if Andrew doesn't pick it up, because
I made a typo in the name of the first patch (shame, shame).

Greetings,
Rafael


-- 
You never change things by fighting the existing reality.
		R. Buckminster Fuller
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/