linux-kernel - Re: [PATCH] ams: remove usage of input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20060920191336.001b2c6a.akpm@osdl.org>
Date:	Wed, 20 Sep 2006 19:13:36 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Dmitry Torokhov <dtor@...ightbb.com>
Cc:	Aristeu Sergio Rozanski Filho <aris@...hedrallabs.org>,
	Michael Hanselmann <linux-kernel@...smi.ch>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ams: remove usage of input_dev cdev

On Wed, 20 Sep 2006 21:59:53 -0400
Dmitry Torokhov <dtor@...ightbb.com> wrote:

> On Wednesday 20 September 2006 20:51, Aristeu Sergio Rozanski Filho wrote:
> > This patch removes usage of 'cdev' member of input_dev, not present
> > on that struct anymore.
> > 
> 
> Where did it go?

Sigh.  That would make a good ./.signature

> > Signed-off-by: Aristeu S. Rozanski F. <aris@...hedrallabs.org>
> > 
> > --- mm.orig/drivers/hwmon/ams/ams-mouse.c	2006-09-20 13:57:59.000000000 -0300
> > +++ mm/drivers/hwmon/ams/ams-mouse.c	2006-09-20 21:01:59.000000000 -0300
> > @@ -66,7 +66,6 @@
> >  	ams_info.idev->name = "Apple Motion Sensor";
> >  	ams_info.idev->id.bustype = ams_info.bustype;
> >  	ams_info.idev->id.vendor = 0;
> > -	ams_info.idev->cdev.dev = &ams_info.of_dev->dev;
> >  
> >  	input_set_abs_params(ams_info.idev, ABS_X, -50, 50, 3, 0);
> >  	input_set_abs_params(ams_info.idev, ABS_Y, -50, 50, 3, 0);
> > 

I think the right fix is s/cdev.dev/d.parent/g.  But Greg has moved all
those patches out of the tree which I'll henceforth be merging into -mm, so
we can stop worrying about it.  
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/