lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Sep 2006 14:03:13 +0100 From: Paulo Marques <pmarques@...popie.com> To: Pekka Enberg <penberg@...helsinki.fi> CC: Jiri Slaby <jirislaby@...il.com>, Om Narasimhan <om.turyx@...il.com>, linux-kernel@...r.kernel.org, kernel-janitors@...ts.osdl.org Subject: Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version] Pekka Enberg wrote: > On 9/22/06, Paulo Marques <pmarques@...popie.com> wrote: >> Agreed on every comment except this one. That complex expression is >> really just a constant in the end, so there is no point in using kcalloc. > > The code is arguably easier to read with kcalloc. I was afraid the kcalloc call would have the added overhead of an extra parameter and a multiplication, but since it is actually declared as a static inline, gcc should optimize everything away (because both parameters are constants) and give the same result in the end. So, its fine by me either way. -- Paulo Marques - www.grupopie.com "The face of a child can say it all, especially the mouth part of the face." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists