linux-kernel - Re: [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:  <45134465.8060703@flower.upol.cz>
Date:	Fri, 22 Sep 2006 04:03:17 +0200
From:	Oleg Verych <olecom@...wer.upol.cz>
To:	linux-kernel@...r.kernel.org
Cc:	Luke Yang <luke.adi@...il.com>
Subject:  Re: [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18

Hallo, Luke Yang, who wrote:
> +static void bfin_serial_mctrl_check(struct bfin_serial_port *uart);
> +
> +/*
> + * interrupts disabled on entry
> + */

spelling error: _are_ disabled
please grep && sed all patches

> +static void bfin_serial_stop_tx(struct uart_port *port)
> +{
> +    struct bfin_serial_port *uart = (struct bfin_serial_port *)port;
> +    unsigned short ier;
> +    ier = UART_GET_IER(uart);
> +    ier &= ~ETBEI;
> +    UART_PUT_IER(uart, ier);
> +#ifdef CONFIG_SERIAL_BFIN_DMA
> +    disable_dma(uart->tx_dma_channel);
> +#endif
> +}

one blank line after local variables; you are using this in some functions, in 
some you are not...

> +
> +static void bfin_serial_shutdown(struct uart_port *port)
> +{
> +    struct bfin_serial_port *uart = (struct bfin_serial_port *)port;
> +

yes, one more space will be nicer

> +    free_irq(uart->port.irq+1, uart);

here and the like


-- 
-o--=O`C
  #oo'L O  5 years ago TT and WTC7 were assassinated
<___=E M  learn more how (tm) <http://911research.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/