[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0609221400230.9370@schroedinger.engr.sgi.com>
Date: Fri, 22 Sep 2006 14:01:48 -0700 (PDT)
From: Christoph Lameter <clameter@....com>
To: Jesse Barnes <jesse.barnes@...el.com>
cc: Martin Bligh <mbligh@...igh.org>, Andi Kleen <ak@...e.de>,
Alan Cox <alan@...rguk.ukuu.org.uk>, akpm@...gle.com,
linux-kernel@...r.kernel.org,
Christoph Hellwig <hch@...radead.org>,
James Bottomley <James.Bottomley@...eleye.com>,
linux-mm@...ck.org
Subject: Re: [RFC] Initial alpha-0 for new page allocator API
On Fri, 22 Sep 2006, Jesse Barnes wrote:
> > + if (dev->coherent_dma_mask < 0xffffffff)
> > + high = dev->coherent_dma_mask;
>
> With your alloc_pages_range this check can go away. I think only the dev
> == NULL check is needed with this scheme since it looks like there's no
> way (currently) for ISA devices to store their masks for later
> consultation by arch code?
This check is necessary to set up the correct high boundary for
alloc_page_range.
> > + if (high == -1L && low == 0L)
> > + return alloc_pages(gfp_flags, order);
>
> There's max_pfn, but on machines with large memory holes using it might not
> help much.
I found node_start_pfn and node_spanned_pages in the node structure. That
gives me the boundaries for a node and I think I can work with that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists