linux-kernel - Re: [BUG] i386 2.6.18 cpu_up: attempt to bring up CPU 4 failed : kernel BUG at mm/slab.c:2698!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64N.0609212033420.9396@attu3.cs.washington.edu>
Date:	Thu, 21 Sep 2006 20:38:07 -0700 (PDT)
From:	David Rientjes <rientjes@...washington.edu>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
cc:	Andrew Morton <akpm@...l.org>, kmannth@...ibm.com,
	linux-kernel@...r.kernel.org, clameter@...r.sgi.com
Subject: Re: [BUG] i386 2.6.18 cpu_up: attempt to bring up CPU 4 failed :
 kernel BUG at mm/slab.c:2698!

On Fri, 22 Sep 2006, KAMEZAWA Hiroyuki wrote:

> Index: linux-2.6.18/mm/page_alloc.c
> ===================================================================
> --- linux-2.6.18.orig/mm/page_alloc.c	2006-09-20 12:42:06.000000000 +0900
> +++ linux-2.6.18/mm/page_alloc.c	2006-09-22 12:22:03.000000000 +0900
> @@ -1844,9 +1844,11 @@
>  
>  	for_each_zone(zone) {
>  		struct per_cpu_pageset *pset = zone_pcp(zone, cpu);
> -
> -		zone_pcp(zone, cpu) = NULL;
> -		kfree(pset);
> +		/* When canceled, zone_pcp still points to boot_pageset[] */
> +		if (zone_pcp(zone, cpu) != &boot_pageset[cpu]) {
> +			zone_pcp(zone, cpu) = NULL;
> +			kfree(pset);
> +		}
>  	}
>  }
>  

Regardless of whether the zone's per_cpu_pageset was set before the slab 
allocator came up or not, it still needs to be NULL before returning from 
here.  Only when it is allocated through kmalloc_node does it need kfree, 
however.

		David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/