linux-kernel - Re: [2/9] driver core fixes: device_register() retval check in platform.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060923211032.GA4363@flint.arm.linux.org.uk>
Date:	Sat, 23 Sep 2006 22:10:32 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
Cc:	Greg K-H <greg@...ah.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [2/9] driver core fixes: device_register() retval check in platform.c

On Fri, Sep 22, 2006 at 11:36:55AM +0200, Cornelia Huck wrote:
> From: Cornelia Huck <cornelia.huck@...ibm.com>
> 
> Check the return value of device_register() in platform_bus_init().
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@...ibm.com>
> 
> ---
>  drivers/base/platform.c |   11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> --- linux-2.6-CH.orig/drivers/base/platform.c
> +++ linux-2.6-CH/drivers/base/platform.c
> @@ -563,8 +563,15 @@ EXPORT_SYMBOL_GPL(platform_bus_type);
>  
>  int __init platform_bus_init(void)
>  {
> -	device_register(&platform_bus);
> -	return bus_register(&platform_bus_type);
> +	int error;
> +
> +	error = device_register(&platform_bus);
> +	if (error)
> +		return error;
> +	error =  bus_register(&platform_bus_type);
> +	if (error)
> +		device_unregister(&platform_bus);
> +	return error;

I don't think there's much value in patches such as this - if the
platform bus type didn't register, what happens when we then try
to register a platform device driver or a platform device?  ISTR
doing that before the bus type is registered leads to an OOPS.

So, presumably to do this properly, if the platform_bus_type failed
to register, you need to force all platform device/platform device
driver registrations to also fail.

At that point, is the added complexity really worth it?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/