lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 22 Sep 2006 21:50:00 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Auke Kok <auke-jan.h.kok@...el.com>
Cc:	Holger Kiehl <Holger.Kiehl@....de>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-net <linux-net@...r.kernel.org>, netdev@...r.kernel.org,
	"Ronciak, John" <john.ronciak@...el.com>
Subject: Re: 2.6.1[78] page allocation failure. order:3, mode:0x20

On Fri, 22 Sep 2006 10:10:36 -0700
Auke Kok <auke-jan.h.kok@...el.com> wrote:

> I wonder if we can't account for NET_IP_ALIGN when selecting bufsize, to get at 
> rid of at least 1 order size before we netdev_alloc_skb. This should make 9k 
> frames only kmalloc(16384) and thus stay within the 16k boundary. I hope.
> 
> Completely untested: don't commit :)
> 

I did - I think we want this patch.

> 
> e1000: account for NET_IP_ALIGN when calculating bufsiz
> 
> Account for NET_IP_ALIGN when requesting buffer sizes from netdev_alloc_skb to 
> reduce slab allocation by half.

Could we please do whatever is needed to get this blessed and merged?  This
is such a common problem on such a common driver that I would suggest that
we want this in 2.6.18.x as well.  At least, I'd expect distributors to
ship this fix (they're nuts if they don't) and so it makes sense to deliver
it from kernel.org.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ