linux-kernel - Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 Sep 2006 20:50:08 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Aubrey <aubreylee@...il.com>
Cc:	"Arnd Bergmann" <arnd@...db.de>, "Luke Yang" <luke.adi@...il.com>,
	linux-kernel@...r.kernel.org, "Andrew Morton" <akpm@...l.org>
Subject: Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18

On Sun, 24 Sep 2006 11:35:31 +0800 Aubrey wrote:

> On 9/23/06, Arnd Bergmann <arnd@...db.de> wrote:
> > > +static uint32_t reloc_stack_operate(unsigned int oper, struct module *mod)
> > > +{
> > > +     uint32_t value;
> > > +     switch (oper) {
> > > +     case R_add:
> > > +             {
> > > +                     value =
> > > +                         reloc_stack[reloc_stack_tos - 2] +
> > > +                         reloc_stack[reloc_stack_tos - 1];
> > > +                     reloc_stack_tos -= 2;
> > > +                     break;
> > > +             }
> >
> > no need for the curly braces here and below
> 
> Hmm, but we need one line < 80 columns, don't we?

Yes (preferably), but:
The braces for case R_add above simply aren't needed at all.
And after they are removed, you can indent the remaining code
one less tab stop.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/