linux-kernel - Re: [PATCH] missing includes from infiniband merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060924064446.GA13320@uranus.ravnborg.org>
Date:	Sun, 24 Sep 2006 08:44:47 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Al Viro <viro@....linux.org.uk>
Cc:	Linus Torvalds <torvalds@...l.org>, rolandd@...co.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] missing includes from infiniband merge

On Sat, Sep 23, 2006 at 09:36:05PM +0100, Al Viro wrote:
> > A better fix would be to avoid the arch dependency in the non-arch .h
> > files so that in most cases it just works??
> 
> What "it"?  Use of vmalloc() without including vmalloc.h since on i386
> it just happens to be pulled via the
> linux/pci.h -> linux/dmapool.h -> asm-i386/io.h -> linux/vmalloc.h
> chain?
The other way around. Try to get rid of the evil includes in arch-$(ASM)
that is just sitting there for no other purpose than to let a developer skip
a single include.
In this case the right fix IMO would have been to kill the include of
linux/vmalloc.h from asm-i386/io.h and let all users that previously failed
to include vmalloc.h now do so themself.

Looking through asm-i386/io.h at fist look there is zero use of
linux/vmalloc.h so the include has no business there.

With this your patch would obviously be needed and on top of this we would
have to fix other places that 'forget' to include vmalloc.h but the good thing
would be that this is now a bit more consistent across architectures.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/