linux-kernel - Re: [PATCH] libata: rework legacy handling to remove much of the cruft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Sep 2006 11:14:50 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, Tejun Heo <htejun@...il.com>,
	rmk@....linux.org.uk
Subject: Re: [PATCH] libata: rework legacy handling to remove much of the
	cruft

On Sun, 2006-09-24 at 18:05 +0000, Linux Kernel Mailing List wrote:
> 
> +#define ATA_PRIMARY_CMD                0x1F0
> +#define ATA_PRIMARY_CTL                0x3F6
> +#define ATA_PRIMARY_IRQ                14
> +
> +#define ATA_SECONDARY_CMD      0x170
> +#define ATA_SECONDARY_CTL      0x376
> +#define ATA_SECONDARY_IRQ      15

Please, don't do this. We've only just cleaned up the serial driver to
get rid of crap like this -- we _don't_ want to do it like this.

We should register the non-discoverable devices as platform devices (or
of_devices, or something), and not just hardcode stuff like this in
asm/foo.h headers.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/