linux-kernel - Re: [PATCH] restore libata build on frv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20660.1159195152@warthog.cambridge.redhat.com>
Date:	Mon, 25 Sep 2006 15:39:12 +0100
From:	David Howells <dhowells@...hat.com>
To:	Al Viro <viro@....linux.org.uk>
Cc:	David Howells <dhowells@...hat.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@...l.org>,
	Jeff Garzik <jgarzik@...ox.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] restore libata build on frv 

Al Viro <viro@....linux.org.uk> wrote:

> Fine by me.  In that case we need to add
> 	depends on !FRV || BROKEN

My point is that all the numbers are invalid or incorrect.  They will cause
the arch to oops, and so need completely replacing.  So that patch you added
is incorrect and should not include asm-generic/libata-portmap.h as nothing in
there is correct on this arch.  So your patch should *not* be applied, but
should instead be replaced.

> to drivers/ata/Kconfig and be done with that.  BTW, empty libata-portmap.h
> is equivalent to absent one - it still won't build.

Why does the arch have to supply those numbers?  What's wrong with my
suggested patch?  According to code in libata, these are _legacy_ access
methods, and on FRV they aren't currently required, so why can't I dispense
with them if they're not needed?  Doing that not only skips legacy accesses
for ISA compatibility, it also reduces the code size by not actually emitting
the code for the accesses, thus making the kernel smaller...

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/