linux-kernel - Re: hvc_iseries.c: overwriting spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060926005838.d0cd5d7e.sfr@canb.auug.org.au>
Date:	Tue, 26 Sep 2006 00:58:38 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	"Alexey Dobriyan" <adobriyan@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: hvc_iseries.c: overwriting spin_lock_irqsave()

Hi Alexy,

On Mon, 25 Sep 2006 16:47:08 +0400 "Alexey Dobriyan" <adobriyan@...il.com> wrote:
>
> Stephen, -git4 contains the following code
> 
> drivers/char/hvc_iseries.c:
> 
> static int put_chars(uint32_t vtermno, const char *buf, int count)
> {
>             unsigned long flags;
> 
>             spin_lock_irqsave(&consolelock, flags);
>             if (viochar_is_console(pi) && !viopath_isactive(pi->lp)) {
>                           spin_lock_irqsave(&consoleloglock, flags);
> 
> So, old flags are lost.

Ooops!  Thanks for the heads up, I will send a fix patch tomorrow.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/