linux-kernel - Re: [PATCH] restore libata build on frv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Sep 2006 04:52:09 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	David Woodhouse <dwmw2@...radead.org>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	David Howells <dhowells@...hat.com>,
	Al Viro <viro@....linux.org.uk>,
	Linus Torvalds <torvalds@...l.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] restore libata build on frv

David Woodhouse wrote:
> On Mon, 2006-09-25 at 16:46 +0100, Alan Cox wrote:
>> Ar Llu, 2006-09-25 am 15:39 +0100, ysgrifennodd David Howells:
>>> Why does the arch have to supply those numbers?  What's wrong with my
>>> suggested patch?  According to code in libata, these are _legacy_ access
>>> methods, and on FRV they aren't currently required, so why can't I dispense
>> "legacy, legacy, legacy" "wont wont wont"
>>
>> The ports in question are PCI values. They come from the PCI
>> specifications and apply to any device with PCI bus, unless it has
>> special mappings. The same logic you are whining about is already partly
>> handled in the generic pci quirks code, and in time will end up with the
>> I/O port value fixups there anyway.
>>
>> See quirk_ide_bases in drivers/pci/quirks.c
> 
> If we can do that with PCI quirks, why the need to hard-code it in the
> IDE driver too?
> 
> And IRQ zero isn't particularly helpful suggestion -- using an invalid
> IRQ number would be better. Like NO_IRQ or IDE_NO_IRQ, which should be
> -1.
> 
> Don't make me dig out the board where the PCI slots all get IRQ 0 :)

The irq is a special case no matter how we try to prettyify it.  We need 
two irqs, and PCI only gives us one per device.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/