linux-kernel - Re: [PATCH 2/2] serio: lockdep annotation for ps2dev->cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1159277799.5038.22.camel@lappy>
Date:	Tue, 26 Sep 2006 15:36:38 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Jiri Kosina <jikos@...os.cz>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Dave Jones <davej@...hat.com>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 2/2] serio: lockdep annotation for ps2dev->cmd_mutex
	and serio->lock

On Tue, 2006-09-26 at 15:21 +0200, Jiri Kosina wrote:

> the lockdep part of the patch (1/2) is OK. The second part, specifically 
> the libps2.c changes, are not complete - the originally (wrongly) 
> introduced mutex_lock_nested() has to be changed back to mutex_lock(), 
> otherwise we will get spurious warning from lockdep about ps2_mutex_key.

Ah, missed that that part was actually in the tree ;-)

> Below is the fixed version of the patch. I confirm that this (together 
> with Peter's original changes in lockdep, already acked by Ingo) fixes the 
> synpatics passthrough port lockdep warnings.
> 
> So, as long as you, Dmitry, seem to be convenient with this approach, 
> please apply. Thanks.
> 
> Signed-off-by: Jiri Kosina <jikos@...os.cz>
Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

Thanks for testing



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/