linux-kernel - Re: pata_serverworks oopses in latest -git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45194DAD.6060904@garzik.org>
Date:	Tue, 26 Sep 2006 11:56:29 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Diego Calleja <diegocg@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: pata_serverworks oopses in latest -git

Alan Cox wrote:
> Ar Maw, 2006-09-26 am 14:00 +0200, ysgrifennodd Diego Calleja:
>> When trying to test the new libata PATA drivers in the latest -git tree, I 
>> got this when udev tried to load the module:
> 
> Yes something seems to be very ill in the -git tree but I'm not sure
> what has changed in the libata core to trigger all this at the moment.

One thing I notice in pata_serverworks.c is the lack of an ->irq_clear() 
hook, which is called unconditionally in ata_device_add().  It's a bit 
strange that it wasn't caught before, since ->irq_clear() has been 
called unconditionally for a great many kernel releases.

Diego, does the attached patch help?

	Jeff

View attachment "patch" of type "text/plain" (698 bytes)