linux-kernel - Re: [PATCH] libata-eh: Remove layering violation and duplication when handling absent ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <451964E1.4090304@pobox.com>
Date:	Tue, 26 Sep 2006 13:35:29 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libata-eh: Remove layering violation and duplication
 when	handling absent ports

Alan Cox wrote:
> This removes the layering violation where drivers have to fiddle
> directly with EH flags. Instead we now recognize -ENOENT means "no port"
> and do the handling in the core code.
> 
> This also removes an instance of a call to disable the port, and an
> identical printk from each driver doing this. Even better - future rule
> changes will be in one place only.
> 
> Signed-off-by: Alan Cox <alan@...hat.com>

applied, but please stop adding trailing whitespace


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/