linux-kernel - Re: [PATCH] libata-sff: use our IRQ defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060926204433.GA77171@dspnet.fr.eu.org>
Date:	Tue, 26 Sep 2006 22:44:33 +0200
From:	Olivier Galibert <galibert@...ox.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	jgarzik@...ox.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libata-sff: use our IRQ defines

On Tue, Sep 26, 2006 at 05:55:37PM +0100, Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@...hat.com>
> 
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-mm1/drivers/ata/libata-sff.c linux-2.6.18-mm1/drivers/ata/libata-sff.c
> --- linux.vanilla-2.6.18-mm1/drivers/ata/libata-sff.c	2006-09-25 12:10:08.000000000 +0100
> +++ linux-2.6.18-mm1/drivers/ata/libata-sff.c	2006-09-25 16:04:41.000000000 +0100
> @@ -881,7 +881,7 @@
>  	probe_ent->private_data = port[0]->private_data;
>  
>  	if (port_mask & ATA_PORT_PRIMARY) {
> -		probe_ent->irq = 14;
> +		probe_ent->irq = ATA_PRIMARY_IRQ;
>  		probe_ent->port[0].cmd_addr = ATA_PRIMARY_CMD;
>  		probe_ent->port[0].altstatus_addr =
>  		probe_ent->port[0].ctl_addr = ATA_PRIMARY_CTL;
> @@ -896,7 +896,7 @@
>  
>  	if (port_mask & ATA_PORT_SECONDARY) {
>  		if (probe_ent->irq)
> -			probe_ent->irq2 = 15;
> +			probe_ent->irq2 = ATA_SECONDARY_IRQ;
>  		else
>  			probe_ent->irq = 15;

Isn't that one supposed to be ATA_SECONDARY_IRQ too?

>  		probe_ent->port[1].cmd_addr = ATA_SECONDARY_CMD;
> 

  OG.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/