linux-kernel - Re: 2.6.18-rt1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060927083628.GD12149@elte.hu>
Date:	Wed, 27 Sep 2006 10:36:28 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	Gene Heskett <gene.heskett@...izon.net>,
	linux-kernel@...r.kernel.org, paulmck@...ibm.com,
	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <johnstul@...ibm.com>,
	Dipankar Sarma <dipankar@...ibm.com>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: 2.6.18-rt1


* Daniel Walker <dwalker@...sta.com> wrote:

> On closer inspection I still think this is wrong. (Although it looks 
> really nice..) find below speaking only in term of !PREEMPT_RT ,

> > -	} else if (oops_in_progress) {
> > -		locked = spin_trylock(&up->port.lock);
> > -	} else
> > -		spin_lock(&up->port.lock);
> > +	if (up->port.sysrq || oops_in_progress)
> > +		locked = spin_trylock_irqsave(&up->port.lock, flags);
> 
> Now in the new version interrupts are only off if you _get the lock_. 
> Presumably the lock is taken in the calling function, but interrupts 
> aren't disabled.
> 
> I'm assuming the code is disabling interrupts for a good reason, I 
> don't know enough about the code to say it isn't.

yeah, agreed - behavior now changed due to my patch. This is really 
twisted code...

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/