linux-kernel - Re: [PATCH 2.6.18 ] LIB Add gen_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060927132728.d01ee9fb.rdunlap@xenotime.net>
Date:	Wed, 27 Sep 2006 13:27:28 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Dean Nelson <dcn@....com>
Cc:	swise@...ngridcomputing.com, jes@...ined-monkey.org,
	avolkov@...ma-el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.18 ] LIB Add gen_pool_destroy().

On Wed, 27 Sep 2006 14:59:29 -0500 Dean Nelson wrote:

> On Wed, Sep 27, 2006 at 08:56:08AM -0700, Randy Dunlap wrote:
> > On Wed, 27 Sep 2006 10:53:25 -0500 Steve Wise wrote:
> > 
> > > > > index 71338b4..c8afa10 100644
> > > > > --- a/lib/genalloc.c
> > > > > +++ b/lib/genalloc.c
> > > > > @@ -36,6 +36,28 @@ EXPORT_SYMBOL(gen_pool_create);
> > > > >  
> > > > >  
> > > > >  /*
> > > > > + * Destroy a memory pool.  Assumes the user deals with releasing the
> > > > > + * actual memory managed by the pool.  
> > > > > + *
> > > > > + * @pool: pool to destroy.
> > > > > + *
> > > > > + */
> > > > 
> > > > Please use kernel-doc for exported kernel interfaces.
> > > > See Documentation/kernel-doc-nano-HOWTO.txt for info,
> > > > and/or see some file like kernel/printk.c for examples.
> > > > 
> > > > > +void gen_pool_destroy(struct gen_pool *pool)
> > > > > +{
> > > > > +	struct list_head *_chunk, *next;
> > > > > +	struct gen_pool_chunk *chunk;
> > > > > +
> > > > > +	list_for_each_safe(_chunk, next, &pool->chunks) {
> > > > > +		chunk = list_entry(_chunk, struct gen_pool_chunk, next_chunk);
> > > > > +		kfree(chunk);
> > > > > +	}
> > > > > +	kfree(pool);
> > > > > +	return;
> > > > > +}
> > > > > +EXPORT_SYMBOL(gen_pool_destroy);
> > > > > +
> > > > > +
> > > > > +/*
> > > > >   * Add a new chunk of memory to the specified pool.
> > > > >   *
> > > > >   * @pool: pool to add new memory chunk to
> > > > > -
> > > > 
> > > > argh.  more.  (not part of your patch)
> > > 
> > > 
> > > I formatted it to align with the rest of the file...
> > 
> > Yes, so I noticed (when I got to the end of the patch).
> > 
> > I suppose I'll queue this up for kernel-doc work.
> 
> Sorry Randy, this was my mistake. I didn't know about kernel-doc.
> I'll put together a patch tommorrow, if that would be alright?
> I don't have the time today.

Sure, no problem.  Thanks for doing that.
I'll review it when you post it.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/