linux-kernel - [Patch] Remove unnecessary check in drivers/rtc/rtc-v3020.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1159397376.14069.5.camel@alice>
Date:	Thu, 28 Sep 2006 00:49:36 +0200
From:	Eric Sesterhenn <snakebyte@....de>
To:	linux-kernel@...r.kernel.org
Cc:	a.zummo@...ertech.it
Subject: [Patch] Remove unnecessary check in drivers/rtc/rtc-v3020.c

hi,

looks like the probe function always gets a valid pdev,
and checking it after dereferencing it is pretty useless.
This patch removes the check (cid #1365)

Signed-off-by: Eric Sesterhenn <snakebyte@....de>

--- linux-2.6.18-git7/drivers/rtc/rtc-v3020.c.orig	2006-09-27 22:18:37.000000000 +0200
+++ linux-2.6.18-git7/drivers/rtc/rtc-v3020.c	2006-09-27 22:18:50.000000000 +0200
@@ -169,9 +169,6 @@ static int rtc_probe(struct platform_dev
 	if (pdev->resource[0].flags != IORESOURCE_MEM)
 		return -EBUSY;
 
-	if (pdev == NULL)
-		return -EBUSY;
-
 	chip = kzalloc(sizeof *chip, GFP_KERNEL);
 	if (!chip)
 		return -ENOMEM;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/