[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20060927.155035.74747595.davem@davemloft.net>
Date: Wed, 27 Sep 2006 15:50:35 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: linux-kernel@...r.kernel.org, akpm@...l.org
Cc: ebiederm@...ssion.com, ak@...e.de, benh@...nel.crashing.org,
greg@...ah.com, mingo@...e.hu, tglx@...utronix.de,
tony.luck@...el.com
Subject: Re: +
msi-refactor-and-move-the-msi-irq_chip-into-the-arch-code.patch added to
-mm tree
From: akpm@...l.org
Date: Wed, 27 Sep 2006 15:15:37 -0700
> Subject: msi: refactor and move the msi irq_chip into the arch code
> From: "Eric W. Biederman" <ebiederm@...ssion.com>
>
> It turns out msi_ops was simply not enough to abstract the architecture
> specific details of msi. So I have moved the resposibility of constructing
> the struct irq_chip to the architectures, and have two architecture specific
> functions arch_setup_msi_irq, and arch_teardown_msi_irq.
>
> For simple architectures those functions can do all of the work. For
> architectures with platform dependencies they can call into the appropriate
> platform code.
>
> With this msi.c is finally free of assuming you have an apic, and this
> actually takes less code.
>
> The helpers for the architecture specific code are declared in the linux/msi.h
> to keep them separate from the msi functions used by drivers in linux/pci.h
>
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Andi Kleen <ak@...e.de>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Greg KH <greg@...ah.com>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Signed-off-by: Andrew Morton <akpm@...l.org>
Eric, thanks so much for doing this work.
Once this goes in I'll try to add support for MSI on sparc64
Niagara boxes. I suppose the PowerPC folks can make use of
this as well.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists