linux-kernel - Re: Tiny error in printk output for clocksource : a3:<6>Time: acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060926221718.7e20613e.rdunlap@xenotime.net>
Date:	Tue, 26 Sep 2006 22:17:18 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Greg KH <greg@...ah.com>, Jesper Juhl <jesper.juhl@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Tiny error in printk output for clocksource : a3:<6>Time:
 acpi_pm clocksource has been installed.

On Tue, 26 Sep 2006 22:10:43 -0700 Joe Perches wrote:

> On Tue, 2006-09-26 at 21:56 -0700, Randy Dunlap wrote:
> > > Nope, that's part of the NIC's MAC address.  It was split up.
> > 
> > Sorry.  In this case, it was via-rhine.c:
> > 
> > 	for (i = 0; i < 5; i++)
> > 		printk("%2.2x:", dev->dev_addr[i]);
> > 	printk("%2.2x, IRQ %d.\n", dev->dev_addr[i], pdev->irq);
> > 
> > so it does break the printk()s up itself.
> 
> Changing all of those MAC address printks to a single function
> could prevent this.
> 
> http://www.uwsg.iu.edu/hypermail/linux/net/0602.1/0002.html

True enough.  Thanks for the patch.
However, in this case, the single-printed MAC address still needs
a \n, with the IRQ on a separate line (wasting vertical screen space),
or it needs a custom printk() that is all done at one time.
Probably the latter IMO.  Oh, it looks like your patch
has a way to handle that too.  Good.
What happened to your patch?

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/