linux-kernel - Re: [PATCH 3/8] at91_serial -> atmel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	28 Sep 2006 10:34:49 +0200
From:	Andrew Victor <andrew@...people.com>
To:	Haavard Skinnemoen <hskinnemoen@...el.com>
Cc:	Russell King <rmk+lkml@....linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] at91_serial -> atmel_serial: Kconfig symbols

hi Haavard,

> Rename the following Kconfig symbols:
>   * CONFIG_SERIAL_AT91 -> CONFIG_SERIAL_ATMEL
>   * CONFIG_SERIAL_AT91_CONSOLE -> CONFIG_SERIAL_ATMEL_CONSOLE
>   * CONFIG_SERIAL_AT91_TTYAT -> CONFIG_SERIAL_ATMEL_TTYAT


> -config SERIAL_AT91
> -	bool "AT91RM9200 / AT91SAM9261 serial port support"
> +config SERIAL_ATMEL
> +	bool "AT91 / AT32 on-chip serial port support"
>  	depends on ARM && (ARCH_AT91RM9200 || ARCH_AT91SAM9261)
>  	select SERIAL_CORE
>  	help
>  	  This enables the driver for the on-chip UARTs of the Atmel
>  	  AT91RM9200 and AT91SAM926 processor.

Shouldn't this dependency be:
   depends on (ARM && ARCH_AT91) || AVR32

(The "ARCH_AT91RM9200 || ARCH_AT91SAM9261" can be replaced with
ARCH_AT91 since the driver should usable on the RM9200, SAM9261 and
SAM9260)

The help text should probably also be updated for these 3 options so
that it mentions the AVR32.


Regards,
  Andrew Victor



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/