| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Sep 2006 16:21:39 +0200 From: Heiko Carstens <heiko.carstens@...ibm.com> To: J?rn Engel <joern@...nheim.fh-wedel.de> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>, linux-kernel@...r.kernel.org, holzheu@...ibm.com Subject: Re: [S390] hypfs sparse warnings. On Thu, Sep 28, 2006 at 03:54:06PM +0200, J?rn Engel wrote: > On Thu, 28 September 2006 15:42:47 +0200, Heiko Carstens wrote: > > On Thu, Sep 28, 2006 at 03:25:40PM +0200, J?rn Engel wrote: > > > On Thu, 28 September 2006 15:07:37 +0200, Martin Schwidefsky wrote: > > > > > > > > sparse complains, if we use bitwise operations on enums. Cast enum to > > > > long in order to fix that problem! > > > > > > At this point I start to wonder which part should be changed. Is it > > > better to > > > a) cast some more, as you started to do, > > > b) change enums to #defines or > > > c) change '|' to '+'? > > > > > > At any rate, you have the same problem in 5 seperate places by my > > > count and only changed 1 of them. Nak - in case anyone cares. > > > > That would be where? My sparse run didn't reveal anything else. > > Search for diag204. All calls have the same format with bitwise or of > two enums, so they are all equally (in-)correct. You probably need to update your git tree. All of them have casts in the meantime. Except for the one addressed with this patch. See: 331c982d4a6b43cdc0d056956a1cae8a7d6237bf - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists