lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Sep 2006 09:08:14 -0700 From: Joe Perches <joe@...ches.com> To: Denis Vlasenko <vda.linux@...glemail.com> Cc: Randy Dunlap <rdunlap@...otime.net>, Greg KH <greg@...ah.com>, Jesper Juhl <jesper.juhl@...il.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: Tiny error in printk output for clocksource : a3:<6>Time: acpi_pm clocksource has been installed. On Thu, 2006-09-28 at 12:56 +0200, Denis Vlasenko wrote: > \#define MACSTR "%02X:%02X:%02X:%02X:%02X:%02X" > #define MAC(bytevector) \ > ((unsigned char *)bytevector)[0], \ > ((unsigned char *)bytevector)[1], \ > ((unsigned char *)bytevector)[2], \ > ((unsigned char *)bytevector)[3], \ > ((unsigned char *)bytevector)[4], \ > ((unsigned char *)bytevector)[5] This is similar to the 802.11 way. 802.11 uses MAC_FMT and MAC_ARG. I think a common style is preferable. It's fine, but it increases the size of kernel image by up to ~100K. Using a common function, a stack automatic and "%s" in the printk decreases the size of the kernel. Strictly, not all MAC addresses are 6 byte. Maybe all the Ethernet/TR addresses should use the IEEE EUI48 designation? That feels a bit like the KiB/KB distinction, but it is technically correct. Would a patch with an DEV6_ADDR->EUI48 substitution be acceptable? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists