linux-kernel - Re: [PATCH] x86: update vmlinux.lds.S to place .data section on a page boundary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060928204220.GA31096@uranus.ravnborg.org>
Date:	Thu, 28 Sep 2006 22:42:20 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Neil Horman <nhorman@...driver.com>
Cc:	linux-kernel@...r.kernel.org, mj@...ey.karlin.mff.cuni.cz,
	davej@...hat.com
Subject: Re: [PATCH] x86: update vmlinux.lds.S to place .data section on a page boundary

On Thu, Sep 28, 2006 at 04:12:49PM -0400, Neil Horman wrote:
> Patch to update vmlinux linker script so that .data section is on a page
> boundary.  without this change the kernel's .data section is on a non-4k
> boundary, and this prevents kexec from loading a new kernel.  Tested
> successfully by me.
NAK

> +  . = ALIGN(4096);

Do not use magic numbers like this.
Please replace 4096 with PAGE_SIZE - page.h is already included so it is
available.
This servers two purposes:
1) This make it more self documenting
2) It makes it more portable should we decide to do this in a general
way for all arch's.

And then maybe a comment why it is desireable to waste a lot of RAM
in some cases. For the embedded people wasting up to 4088 bytes
of RAM is not desireable.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/