linux-kernel - Re: [linux-usb-devel] [GIT PATCH] More USB patches for 2.6.18

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060928172037.69a6a401.akpm@osdl.org>
Date:	Thu, 28 Sep 2006 17:20:37 -0700
From:	Andrew Morton <akpm@...l.org>
To:	David Brownell <david-b@...bell.net>
Cc:	linux-usb-devel@...ts.sourceforge.net,
	Linus Torvalds <torvalds@...l.org>, Greg KH <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [linux-usb-devel] [GIT PATCH] More USB patches for 2.6.18

On Thu, 28 Sep 2006 17:08:33 -0700
David Brownell <david-b@...bell.net> wrote:

> > --- a/drivers/usb/host/ohci-hub.c~ohci-add-auto-stop-support-hack-hack
> > +++ a/drivers/usb/host/ohci-hub.c
> > @@ -132,6 +132,10 @@ static inline struct ed *find_head (stru
> >  	return ed;
> >  }
> >  
> > +#ifdef CONFIG_PM
> > +static int ohci_restart(struct ohci_hcd *ohci);
> > +#endif
> > +
> >  /* caller has locked the root hub */
> 
> Better to just always include the forward decl... much cleaner!

See other email.

> ... reviewing and testing those new OHCI changes is still on my
> list;

erm, we prefer to do that before code hits mainline.

> all that suspend stuff needs care, things that work on PCs don't
> necessarily work on embedded hardware (where OHCI is common, and
> PM tends to be more critical).

I guess we'll find out.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/