[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <39e6f6c70609290740s79bf0b1cwe0b64eef8074eeeb@mail.gmail.com>
Date: Fri, 29 Sep 2006 11:40:43 -0300
From: "Arnaldo Carvalho de Melo" <arnaldo.melo@...il.com>
To: "Gerrit Renker" <gerrit@....abdn.ac.uk>
Cc: "Andrew Morton" <akpm@...l.org>,
"Ian McDonald" <ian.mcdonald@...di.co.nz>,
"Jesper Juhl" <jesper.juhl@...il.com>,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
dccp@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
"Pekka Savola" <pekkas@...core.fi>,
"James Morris" <jmorris@...ei.org>,
"Hideaki YOSHIFUJI" <yoshfuji@...ux-ipv6.org>,
"Patrick McHardy" <kaber@...eworks.de>,
"Alexey Kuznetsov" <kuznet@....inr.ac.ru>
Subject: Re: [PATCH] IPv6/DCCP: Remove unused IPV6_PKTOPTIONS code
On 9/29/06, Gerrit Renker <gerrit@....abdn.ac.uk> wrote:
> > Coverity found what looks like a real leak in net/dccp/ipv6.c::dccp_v6_do_rcv()
>
> | otoh, it seems to me that opt_skb doesn't actually do anything and can be
> | removed?
> This is right, there is no code referencing opt_skb: compare with net/ipv6/tcp_ipv6.c.
> Until someone has time to add the missing DCCP-specific code, it does seem better
> to replace the dead part with a FIXME. This is done by the patch below, applies to
> davem-net2.6 and has been tested to compile.
Thanks, I've been again sidetracked by Real Life(tm) but hopefully
tomorrow I'll go over all the DCCP pending patches backlog and get
them into tree to submit to Dave.
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists