linux-kernel - Re: [PATCH] include children count, in Threads: field present in /proc/<pid>/status (take-1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 Sep 2006 02:18:12 +0900
From:	girish <girishvg@...il.com>
To:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
Cc:	linux-kernel@...r.kernel.org, William Pitcock <nenolod@...eme.org>
Subject: Re: [PATCH] include children count, in Threads: field present in /proc/<pid>/status (take-1)


On Sep 30, 2006, at 2:06 AM, Jan Engelhardt wrote:

>>>>
>>>> -	buffer += sprintf(buffer, "Threads:\t%d\n", num_threads);
>>>> +	buffer += sprintf(buffer, "Threads:\t%d\n", num_threads +
>>>> num_children);
>>>
>>> Personally, I'd prefer the children count to be separate,  
>>> something like:
>>>
>>> buffer += sprintf(buffer, "Threads:\t%d (%d children, %d total)",
>>> num_threads, num_children, num_threads + num_children);
>>>
>>> That would be rather nice, indeed.
>
> And I would suggest three separate lines to keep it parseable!
>
>
> Jan Engelhardt
> -- 

How about this?

         buffer += sprintf(buffer, "Threads:\t%d", num_threads);
         if (num_children)
                 buffer += sprintf(buffer, " Children: %d Total: %d",  
num_children, num_threads + num_children);
         buffer += sprintf(buffer, "\n");

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/