linux-kernel - Re: KDB blindly reads keyboard port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060929180110.GA4021@intel.com>
Date:	Fri, 29 Sep 2006 11:01:10 -0700
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
Cc:	Keith Owens <kaos@....com>, linux-kernel@...r.kernel.org,
	linux-ia64@...r.kernel.org
Subject: Re: KDB blindly reads keyboard port

On Fri, Sep 29, 2006 at 10:57:41AM -0600, Bjorn Helgaas wrote:
>   acpi_parse_fadt: acpi_kbd_controller_present 0

The logic in the kernel seems backwards here though.  We start
by assuming there is a keyboard, then when parsing the FADT
we reset this assumption if the BAF_8042_KEYBOARD_CONTROLLER
bit isn't set.  Which in turn forced SGI to include some
workaround code for their older PROM (which doesn't provide
the FADT table).

There's also a risk that if some code might get added that
runs before we parse FADT that could be confused into thinking
that the keyboard is present.

Wouldn't it be simpler/better to assume there is no keyboard until
we find positive evidence that there is one?

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/