linux-kernel - Re: [GIT PATCH] More USB patches for 2.6.18

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200609290051.k8T0psZL014050@laptop13.inf.utfsm.cl>
Date:	Thu, 28 Sep 2006 20:51:54 -0400
From:	"Horst H. von Brand" <vonbrand@....utfsm.cl>
To:	Andrew Morton <akpm@...l.org>
cc:	Linus Torvalds <torvalds@...l.org>, Greg KH <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, linux-usb-devel@...ts.sourceforge.net
Subject: Re: [GIT PATCH] More USB patches for 2.6.18 

Andrew Morton <akpm@...l.org> wrote:

[...]

> That's the "some gccs dont like static function decls in that scope" thing.
> 
> I fixed it (unpleasantly) like this:
> 
> 
> diff -puN drivers/usb/host/ohci-hub.c~ohci-add-auto-stop-support-hack-hack drivers/usb/host/ohci-hub.c
> --- a/drivers/usb/host/ohci-hub.c~ohci-add-auto-stop-support-hack-hack
> +++ a/drivers/usb/host/ohci-hub.c
> @@ -132,6 +132,10 @@ static inline struct ed *find_head (stru
>  	return ed;
>  }
>  
> +#ifdef CONFIG_PM
> +static int ohci_restart(struct ohci_hcd *ohci);
> +#endif
> +

The #ifdef is unneeded here.

>  /* caller has locked the root hub */
>  static int ohci_rh_resume (struct ohci_hcd *ohci)
>  __releases(ohci->lock)
> @@ -181,8 +185,6 @@ __acquires(ohci->lock)
>  #ifdef	CONFIG_PM
>  	if (status == -EBUSY) {
>  		if (!autostopped) {
> -			static int ohci_restart (struct ohci_hcd *ohci);
> -
>  			spin_unlock_irq (&ohci->lock);
>  			(void) ohci_init (ohci);
>  			status = ohci_restart (ohci);
> _
> 
> -
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239
Casilla 110-V, Valparaiso, Chile               Fax:  +56 32 2797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/