linux-kernel - Re: [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200609301233.45871.arnd@arndb.de>
Date:	Sat, 30 Sep 2006 12:33:45 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Linas Vepstas <linas@...tin.ibm.com>
Cc:	jeff@...zik.org, akpm@...l.org, netdev@...r.kernel.org,
	James K Lewis <jklewis@...ibm.com>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info.

Am Saturday 30 September 2006 01:21 schrieb Linas Vepstas:
> This patch adds version information as reported by
> ethtool -i to the Spidernet driver.
>
> From: James K Lewis <jklewis@...ibm.com>
> Signed-off-by: James K Lewis <jklewis@...ibm.com>
> Signed-off-by: Linas Vepstas <linas@...tin.ibm.com>
> Cc: Arnd Bergmann <arnd@...db.de>

Same comment as last time this was submitted:

> @@ -2303,6 +2304,8 @@ static struct pci_driver spider_net_driv
>   */
>  static int __init spider_net_init(void)
>  {
> +       printk("spidernet Version %s.\n",VERSION);
> +
>         if (rx_descriptors < SPIDER_NET_RX_DESCRIPTORS_MIN) {
>                 rx_descriptors = SPIDER_NET_RX_DESCRIPTORS_MIN;
>                 pr_info("adjusting rx descriptors to %i.\n",

This is missing a printk level and a space character. More importantly,
you should not print the presence of the driver to the syslog, but
the presence of a device driven by it.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/